fix: remove thresholdRange label in double-range tool settings#5931
Open
GhadeerAlbattarni wants to merge 2 commits intoOHIF:masterfrom
Open
fix: remove thresholdRange label in double-range tool settings#5931GhadeerAlbattarni wants to merge 2 commits intoOHIF:masterfrom
GhadeerAlbattarni wants to merge 2 commits intoOHIF:masterfrom
Conversation
✅ Deploy Preview for ohif-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Fixes #5894
The
ThresholdRangelabel was overlapping with the range values in label maps tools panel.Changes & Results
Removed the separate label (
option.name) fromrenderDoubleRangeSettinginToolSettings.tsx.Before
The label "ThresholdRange" overlapped with the double-range
slider values.
After
The double-range slider renders cleanly without an overlapping label.
Testing
Checklist
PR
semantic-release format and guidelines.
Code
etc.)
Public Documentation Updates
additions or removals.
Tested Environment
Greptile Summary
This PR fixes a UI overlap bug where the "ThresholdRange" label was rendering on top of the double-range slider values in the segmentation tool settings panel. The fix removes the external label wrapper (
option.namerendered viarenderLabelWithTooltip) fromrenderDoubleRangeSetting, lettingRowDoubleRangerender directly without an overlapping heading.double-rangesetting type acrossmodes/tmtv,modes/preclinical-4d, andmodes/segmentationare exclusivelyThresholdRangesliders — so removing the label has no unintended impact on other settings.RowDoubleRangealready exposes built-inlabel/showLabelprops that could be used in the future if a label is ever needed for adouble-rangesetting without overlap issues.renderSelectSettingis a pure formatting refactor (collapsing a multi-line<div>to one line) with no functional impact.Confidence Score: 5/5
Safe to merge — a minimal, targeted fix with no functional regressions.
The change is a small one-function edit that removes a confirmed overlapping UI element. All existing usages of
double-rangeare forThresholdRangesliders where the label is redundant. No logic, data, or API contracts are affected.No files require special attention.
Important Files Changed
renderDoubleRangeSettingsoRowDoubleRangerenders directly without the overlapping "ThresholdRange" label; also collapses a multi-line div inrenderSelectSettingto a single line (formatting only).Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[ToolSettings renders option] --> B{option.type} B -->|double-range| C[renderDoubleRangeSetting] C --> D["RowDoubleRange (direct, no label wrapper)"] D --> E["Numeric.Container (doubleRange mode)"] E --> F["Numeric.DoubleRange (showNumberInputs)"] B -->|range| G[renderRangeSetting] G --> H["div wrapper with label + RowInputRange"] B -->|select| I[renderSelectSetting] I --> J["div wrapper with label + Select"] style C fill:#90ee90 style D fill:#90ee90Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'upstream/m..." | Re-trigger Greptile